I noticed that too and I wanted to share it here. But then I couldn't reproduce the error. But now, thanks to your post, @Markus ,I now know... yes, this always happens when the link is followed by a line break.

Workaround: Include the link in [url][/url].

@Der Pepe (Hubzilla) ⁂ ⚝ ah ok, thanks for the workaround!

@Markus Thanks, that's a great test case. I'll add it to the bbcode and markdown tests and see if I can get it fixed.

Also, when viewed on other platforms, it ignores the line breaks and puts everything on one line.

@Scott M. Stolz That's a fundamental incompatibility between BBCode and both Markdown and HTML. Both Markdown and HTML expects whitespace to be insignificant, that is, a space, newline, tab, etc are treated the same, and multiple of either is collapsed to one space char. The exception is within <pre> or Markdown code blocks. It's possible to insert a hard line break in Markdown by either ending the line with a \ or by two space chars and a newline.

BBCode on the other hand treats newlines as significant, so a single \n char will translate to a <br /> tag in HTML. At least the way it's being used by Hubzilla.

Not sure how important we feel it is to keep the existing newline handling in BBCode, or if we should align it with how Markdown and HTML operate?

It causes quite a bit of extra complexity wrt mixing Markdown and BBCode as it is now.</pre>

@Der Pepe (Hubzilla) ⁂ ⚝ Side-effect of this: It breaks the Bookmarks app functionality. But this also means that the pesky "#^" before links is not generated.

@Der Pepe (Hubzilla) ⁂ ⚝ Same here - thanks for the url fix - however, never had this before.

@Harald Eilertsen i think that is a regresseion from the recent codeblock fix.

Not sure how important we feel it is to keep the existing newline handling in BBCode, or if we should align it with how Markdown and HTML operate?

I am afraid changing this will break tons of existing content...

@Mario Vavti That's what I'm worried about too...

Found the issue btw, and have submitted a merge request to fix it. The problem was that at some point, the regex for detecting URLs in the cleanup_bbcode function had been broken across two lines, which made it think that the newline was a valid character and a part of the URL.

Took a while to drill down to this one. As neither the bbcode parser, nor the markdown parser displayed the artifact on their own. The cleanup_bbcode function is only called by the Item module when a post is posted (or previewed).

This is also the code that's responsible for adding the #^ in front of URL's.

@Harald Eilertsen

Not sure how important we feel it is to keep the existing newline handling in BBCode, or if we should align it with how Markdown and HTML operate?

Do we send HTML or BBCode via ActivityPub?

@Scott M. Stolz My guess would be HTML, but I'm sure @Mario Vavti has more info on that.

@Harald Eilertsen If it is HTML, we probably should send <pre><code> and not just <code>.

I noticed the issue when my reply had a code block and it was formatted incorrectly in a NodeBB thread.

@Scott M. Stolz we send both, HTML and text/bbcode.